Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rotate! and reflect! functions #283

Closed
wants to merge 2 commits into from

Conversation

amontoison
Copy link
Member

No description provided.

Copy link
Member

@jpsamaroo jpsamaroo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

src/blas/highlevel.jl Outdated Show resolved Hide resolved
src/blas/highlevel.jl Outdated Show resolved Hide resolved
test/rocarray/blas.jl Outdated Show resolved Hide resolved
test/rocarray/blas.jl Outdated Show resolved Hide resolved
@amontoison
Copy link
Member Author

amontoison commented Sep 13, 2022

@jpsamaroo
off topic: Do you know if it's possible to add a generic fallback for reflect! in GPUArrays.jl?
I don't know how to implement it without a kernel.

amontoison and others added 2 commits September 13, 2022 16:33
Co-authored-by: Julian Samaroo <jpsamaroo@gmail.com>
@pxl-th
Copy link
Member

pxl-th commented Sep 2, 2023

Superseded by #484

@pxl-th pxl-th closed this Sep 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants