Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CUDA.Mem.unregister fails with CUDA.jl 5.4 (not with 5.3) #2452

Closed
omlins opened this issue Jul 22, 2024 · 5 comments · Fixed by #2470
Closed

CUDA.Mem.unregister fails with CUDA.jl 5.4 (not with 5.3) #2452

omlins opened this issue Jul 22, 2024 · 5 comments · Fixed by #2470
Labels
bug Something isn't working

Comments

@omlins
Copy link
Contributor

omlins commented Jul 22, 2024

It seems like the method register(::CUDA.HostMemory) required by CUDA.Mem.unregister has been removed.

The error message is the following (observed in the unit tests from ImplicitGlobalGrid.jl):

  MethodError: no method matching register(::CUDA.HostMemory)
  
  Closest candidates are:
    register(::Type{CUDA.HostMemory}, ::Ptr, ::Integer, ::Any)
     @ CUDA /scratch/snx3000tds/julia/omlins/daint-gpu/packages/CUDA/Tl08O/lib/cudadrv/memory.jl:167
    register(::Type{CUDA.HostMemory}, ::Ptr, ::Integer)
     @ CUDA /scratch/snx3000tds/julia/omlins/daint-gpu/packages/CUDA/Tl08O/lib/cudadrv/memory.jl:167
  
  Stacktrace:
    [1] unregister(args::CUDA.HostMemory)
      @ CUDA.Mem ./deprecated.jl:105
@omlins omlins added the bug Something isn't working label Jul 22, 2024
@maleadt
Copy link
Member

maleadt commented Aug 20, 2024

This is a typo in the method deprecation. I'd advise moving away from those deprecated functions though.

@omlins
Copy link
Contributor Author

omlins commented Aug 21, 2024

@maleadt : thanks!

I'd advise moving away from those deprecated functions though.

Could you tell me how this functionality is exposed in future? Which order functions to be used?

@maleadt
Copy link
Member

maleadt commented Aug 21, 2024

See https://juliagpu.org/post/2024-05-28-cuda_5.4/; the Mem submodule has been removed.

@omlins
Copy link
Contributor Author

omlins commented Sep 17, 2024

@maleadt Could you release soon a new version? We keep running into this error here... Thanks!

@maleadt
Copy link
Member

maleadt commented Sep 17, 2024

Sure, there's a couple of PRs I want merged, but I'll tag a release after that.

Isn't it easier to just fix the use of the deprecated function though?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants