Enzyme: add make_zero of cuarrays

[wsmoses]

[only downstream]

[maleadt]

Enzyme CI fails.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 9.27%. Comparing base (830c49b) to head (6e5d565).
Report is 5 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #2600       +/-   ##
==========================================
- Coverage   73.51%   9.27%   -64.25%     
==========================================
  Files         157     157               
  Lines       15207   15025      -182     
==========================================
- Hits        11180    1394     -9786     
- Misses       4027   13631     +9604     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[wsmoses]

@maleadt okay fixed!

[maleadt]

Still fails. Please have a look at the CI logs.

[wsmoses]

oh apologies, I just saw the green and assumed it was fine

[maleadt]

The last build failed to even precompile the extension:

      From worker 2:	ERROR: LoadError: UndefVarError: `FT` not defined
      From worker 2:	Stacktrace:
      From worker 2:	 [1] top-level scope
      From worker 2:	   @ /var/lib/buildkite-agent/builds/gpuci-15/julialang/cuda-dot-jl/ext/EnzymeCoreExt.jl:583
      From worker 2:	 [2] include
      From worker 2:	   @ ./Base.jl:495 [inlined]
      From worker 2:	 [3] include_package_for_output(pkg::Base.PkgId, input::String, depot_path::Vector{String}, dl_load_path::Vector{String}, load_path::Vector{String}, concrete_deps::Vector{Pair{Base.PkgId, UInt128}}, source::String)
      From worker 2:	   @ Base ./loading.jl:2285
      From worker 2:	 [4] top-level scope
      From worker 2:	   @ stdin:3
      From worker 2:	in expression starting at /var/lib/buildkite-agent/builds/gpuci-15/julialang/cuda-dot-jl/ext/EnzymeCoreExt.jl:2
      From worker 2:	in expression starting at stdin:3

A rebase won't fix this, so cancelling the outstanding builds.

@wsmoses Please verify locally things work first.

[wsmoses]

Fixed/verified locally

Test Summary: |  Pass  Broken  Total  Time
  Overall     | 27434      11  27445      
    SUCCESS
     Testing CUDA tests passed 

(CUDA) pkg> ^C

julia> 

[maleadt]

Testing now exceeds the 30min limit.

[wsmoses]

trying it with an hour to see if it's fine

[wsmoses]

however, it looks like this was already happening previously, so not due to this PR presumably: https://buildkite.com/julialang/cuda-dot-jl/builds/5616#0193de0a-806e-4e36-af34-2abfe9fa437d

[maleadt]

Testing still fails

Error in testset extensions/enzyme:
Error During Test at /var/lib/buildkite-agent/builds/gpuci-5/julialang/cuda-dot-jl/test/extensions/enzyme.jl:10
  Got exception outside of a @test
  UndefVarError: `T` not defined
  Stacktrace:
    [1] make_zero!
      @ /var/lib/buildkite-agent/builds/gpuci-5/julialang/cuda-dot-jl/ext/EnzymeCoreExt.jl:593 [inlined]

[maleadt]

This is wrong: 6bdb146

[wsmoses]

Yeah okay will fix, but also I’m now confused from a high level. There an obvious undef var usage in the patch (which I will fix), which breaks CI but I never hit locally just running test.

is this not run as part of the default tests?

[wsmoses]

@maleadt okay all properly passes now (and runs in 31mins it seems)