Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CuPtr should be Ptr in cudnnGetDropoutDescriptor #397

Closed
denizyuret opened this issue Aug 27, 2020 · 3 comments · Fixed by #408
Closed

CuPtr should be Ptr in cudnnGetDropoutDescriptor #397

denizyuret opened this issue Aug 27, 2020 · 3 comments · Fixed by #408
Labels
bug Something isn't working cuda libraries Stuff about CUDA library wrappers.

Comments

@denizyuret
Copy link
Contributor

(cudnnDropoutDescriptor_t, cudnnHandle_t, CuPtr{Cfloat},

@maleadt maleadt added bug Something isn't working cuda libraries Stuff about CUDA library wrappers. labels Aug 28, 2020
@maleadt
Copy link
Member

maleadt commented Aug 28, 2020

And states should be a CuPtr, right? Feel free to directly edit this, both in libcudnn.jl and in the pointer.json (used during wrapper generation).

@denizyuret
Copy link
Contributor Author

I cannot seem to locate the pointer.json file. Can you explain how wrappers are generated so my fixes don't disappear when we generate wrappers for the next cudnn version? I found another issue with cudnnMultiHeadAttnForward at libcudnn.jl:1991 -- the first two pointers should be CuPtrs.

@vchuravy
Copy link
Member

vchuravy commented Sep 2, 2020

@denizyuret denizyuret linked a pull request Dec 11, 2020 that will close this issue
25 tasks
@denizyuret denizyuret removed a link to a pull request Dec 11, 2020
25 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cuda libraries Stuff about CUDA library wrappers.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants