Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use LLVMLoopInfo.jl #104

Closed
maleadt opened this issue Jun 7, 2023 · 1 comment · Fixed by #107
Closed

Use LLVMLoopInfo.jl #104

maleadt opened this issue Jun 7, 2023 · 1 comment · Fixed by #107

Comments

@maleadt
Copy link
Member

maleadt commented Jun 7, 2023

It's a bit weird to depend on all of KernelAbstractions.jl just for its @unroll macro. As it just uses LLVM loopinfo, we should use LLVMLoopInfo.jl instead: https://github.com/JuliaSIMD/LLVMLoopInfo.jl
@thomasfaingnaert
Copy link
Member

Alternatively, since we only need @unroll, lift that from LLVMLoopInfo and include it in GemmKernels so we don't have any dependencies (unless that involves a significant amount of code, of course).

@maleadt maleadt mentioned this issue Jun 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace KernelAbstractions with LLVMLoopInfo. JuliaGPU/GemmKernels.jl
2 participants
@maleadt @thomasfaingnaert