Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Benchmark bot #115

Closed
maleadt opened this issue Jun 28, 2023 · 2 comments · Fixed by #116
Closed

Benchmark bot #115

maleadt opened this issue Jun 28, 2023 · 2 comments · Fixed by #116

Comments

@maleadt
Copy link
Member

maleadt commented Jun 28, 2023

It'd be great to have a bot that comments with benchmark results on every pull request. I think we can do this using a Buildkite job that has access to the Github token (which isn't available to third-party PRs, but bors could help here), storing previous benchmark results in a branch, and comparing to whatever has been stored.

Open questions/considerations:

  • store all commits, for historical purposes?
  • it should edit any existing comment
@thomasfaingnaert
Copy link
Member

I'd definitely keep the benchmark results for all commits.
Some other things to think about:

  1. Which GPU architectures will we run the benchmarks on?
  2. Which version(s) of Julia will we use?

I suppose we want to get a coverage that is as wide as possible, so Pascal, Volta, Turing, Ampere, Ada Lovelace, and Hopper for (1), and all Julia versions supported in CI/CD for (2)?

@maleadt
Copy link
Member Author

maleadt commented Jun 29, 2023

Which GPU architectures will we run the benchmarks on?

The benchmark queue currently has a single worker with a NVIDIA GeForce RTX 2070.

Which version(s) of Julia will we use?

I propose using the latest stable version, and treating a Julia version update as something that we need to benchmark. Benchmarking across all versions of Julia would be better, but I'm not sure how to best manage that. I think it would make the benchmark comment much more heavyweight.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants