You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It'd be great to have a bot that comments with benchmark results on every pull request. I think we can do this using a Buildkite job that has access to the Github token (which isn't available to third-party PRs, but bors could help here), storing previous benchmark results in a branch, and comparing to whatever has been stored.
Open questions/considerations:
store all commits, for historical purposes?
it should edit any existing comment
The text was updated successfully, but these errors were encountered:
I'd definitely keep the benchmark results for all commits.
Some other things to think about:
Which GPU architectures will we run the benchmarks on?
Which version(s) of Julia will we use?
I suppose we want to get a coverage that is as wide as possible, so Pascal, Volta, Turing, Ampere, Ada Lovelace, and Hopper for (1), and all Julia versions supported in CI/CD for (2)?
Which GPU architectures will we run the benchmarks on?
The benchmark queue currently has a single worker with a NVIDIA GeForce RTX 2070.
Which version(s) of Julia will we use?
I propose using the latest stable version, and treating a Julia version update as something that we need to benchmark. Benchmarking across all versions of Julia would be better, but I'm not sure how to best manage that. I think it would make the benchmark comment much more heavyweight.
It'd be great to have a bot that comments with benchmark results on every pull request. I think we can do this using a Buildkite job that has access to the Github token (which isn't available to third-party PRs, but
bors
could help here), storing previous benchmark results in a branch, and comparing to whatever has been stored.Open questions/considerations:
The text was updated successfully, but these errors were encountered: