Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't run benchmarks on the master branch? #449

Closed
maleadt opened this issue Oct 4, 2024 · 2 comments
Closed

Don't run benchmarks on the master branch? #449

maleadt opened this issue Oct 4, 2024 · 2 comments

Comments

@maleadt
Copy link
Member

maleadt commented Oct 4, 2024

See e.g. #448, which has a benchmarks report in #448 (review), but also after getting merged in da83511#commitcomment-147569793. I don't think the latter is ever going to be looked at.

Can we disable benchmarks on the master branch, or are reference results saved there and thus should we only disable the reporting?

cc @christiangnrd
@maleadt maleadt changed the title Don't run benchmarks on the master branch Don't run benchmarks on the master branch? Oct 4, 2024
@christiangnrd
Copy link
Contributor

Reference results are saved there. I opened #450.

@christiangnrd
Copy link
Contributor

#450 worked

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@maleadt @christiangnrd