Handle NCCL.avg correctly
#54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
|
Thanks. CI failure seems related though. |
maleadt
reviewed
Feb 27, 2024
Comment on lines
+36
to
+37
| # Handles the case where user directly passed in the ncclRedOp_t (eg. `NCCL.avg`) | ||
| ncclRedOp_t(x::ncclRedOp_t) = x |
There was a problem hiding this comment.
This also shouldn't be required when the conversion happens implicitly using convert. But since this doesn't change the end-user API, we can change that later.
There was a problem hiding this comment.
Line 17 in 3a49978
There was a problem hiding this comment.
Yeah I know, I'm just saying that there's a better fix than adding a no-op function, namely by relying on convert to do the conversion when necessary. It's fine adding this now, it was more of a mental note that we need to rework the conversion at some later point :-)
Let me look into that |
|
It should be good now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.