Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename MixedFormat? #15

Closed
evetion opened this issue Mar 29, 2022 · 2 comments
Closed

Rename MixedFormat? #15

evetion opened this issue Mar 29, 2022 · 2 comments

Comments

@evetion
Copy link
Member

evetion commented Mar 29, 2022

Mixed has always been a bit unclear to me. Maybe we could go for Extended (like Extended WKB/WKT, which hold a CRS on top of the normal WKT), or Combined? Or just GeomCRS to remove any ambiguity altogether?

@rafaqz
Copy link
Member

rafaqz commented Mar 31, 2022

Totally, it's a pretty vague name. Maybe Extended suggests that we know it has both, but actually Mixed is also the default when you don't know the contents besides that it is well known text/binary. Maybe it should be UnknownFormat ? The result is kind of the same as for extended in practice - we would just try using it with GDAL for the required case and see if it works.

@rafaqz
Copy link
Member

rafaqz commented Apr 2, 2022

Ah I think I misunderstood this a little from the title.

Maybe we can keep MixedFormat (which shows that a type can be either format) and split the Mixed trait into Extended and Unknown? Then so we can mark either that it does in fact contain both Geometry and CRS, or that we don't know what it contains.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants