Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make empty CRS possible #29

Open
evetion opened this issue Sep 18, 2023 · 8 comments
Open

Make empty CRS possible #29

evetion opened this issue Sep 18, 2023 · 8 comments

Comments

@evetion
Copy link
Member

evetion commented Sep 18, 2023

#sdsl23

And set it to the engineering crs?

@visr
Copy link
Member

visr commented Sep 18, 2023

What is the engineering CRS? Do you have a reference?

@evetion
Copy link
Member Author

evetion commented Sep 19, 2023

See geopandas/geopandas#3019

@edzer
Copy link

edzer commented Nov 10, 2023

What is the engineering CRS? Do you have a reference?

engineering CRS means it can be anything, but is metric (distances in Euclidian space, not angles). See e.g. Iliffe & Lott

@visr
Copy link
Member

visr commented Nov 10, 2023

Thanks, that goes on my reading list.

@rafaqz
Copy link
Member

rafaqz commented Nov 10, 2023

So to calarify: we need no-arg constructors that insert the engineering crs for epsg/wkt/proj etc ?

@edzer
Copy link

edzer commented Nov 10, 2023

So to clarify: we need no-arg constructors that insert the engineering crs for epsg/wkt/proj etc ?

The engineering CRS (wkt in geopandas issue) needs to be inserted when you write a GPKG using GDAL and you want to avoid that GDAL sets a long/lat, geodetic coordinates CRS to the GPKG, which it does by default.

Whether you want to use that WKT more general is up to you; R/sf uses an NA crs, but tries to convey to users that in such cases the coordinates are assumed to be projected and not geodetic. I think it is useful that that assumption is made clear.

@rafaqz
Copy link
Member

rafaqz commented Nov 10, 2023

Yeah sorry was unclear, that was more a technical question for @evetion about the issue as Im not sure what is actually actionable here.

Users/other packages like ArchGDAL/Rasters can already construct such a wkt to pass to gdal manually, the question is if the idea is to make that easy with no-arg constructors.

So e.g. WellKnownText() means the engineering crs.

@evetion
Copy link
Member Author

evetion commented Nov 10, 2023

Yeah, so either always use the eng.crs. when unknown, or use an NA one (unknown) and only set eng.crs when writing to file?

Relates to #30 as well (spherical/cartesian) as type parameter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants