Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add operations for Extent type #106

Open
henrik-wolf opened this issue Jul 24, 2023 · 3 comments
Open

Add operations for Extent type #106

henrik-wolf opened this issue Jul 24, 2023 · 3 comments

Comments

@henrik-wolf
Copy link

Would it be possible to add the appropriate GeoInterface methods (intersects, intersection, contains, union...) for the Extents.Extent type to this package?
It feels a bit strange to have GeoInterface everywhere, except when working with extents, where you have to qualify the operations.

Ideally, this should go into Extents itself, but that does not seem possible. (and would this be considered type piracy? I am not sure, since GeoInterface owns the methods...)

@evetion
Copy link
Member

evetion commented Jul 24, 2023

Yeah, we should add those methods here. Good catch.

@rafaqz
Copy link
Member

rafaqz commented Aug 2, 2023

We should fill out all these methods in Extents.jl for just comparing extents with each other, which we partly have already and I'm extending in rafaqz/Extents.jl#13

Then we can use those to build GeoInterface methods here on geometries with extents.

Extents.jl cant add GeoInterface methods because the dependency is the other way around

@evetion
Copy link
Member

evetion commented Aug 2, 2023

Nice, this is exactly what I wanted to make an issue about, missing methods (within, etc) in Extents, that I can cover with GeoInterface. Will have a draft PR up soon for related work here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants