-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can't plot geometry wrapper types #110
Comments
Yeah you need to do I recently did this: It would be so much better if it just worked, but the dependency structure makes that impossible. I wish we could load packages in extensions then we could just load GeoInterfaceRecipes.jl if Plots.jl was around. I've also wondered if we can hack in an |
Ah, of course, I forgot I explicitly needed to load it. |
Probably everyone will do that tho... what do you think about doing the the |
Why can't we make GeoInterfaceRecipes a proper extension depending on Plots? |
Extensions can only extend existing methods AFAIK. Not even sure whether recipes would count as such, probably not. |
The problem is other packages need to use the macro even when Plots is not avalable, or everyone has to do it in extensions. But we can do both with the |
If we're able to drop the GeometryBasics dependency in GeoInterfaceMakie, then it could be included as an extension on MakieCore! That solves the circular dependency issue, and we can probably pass polygons as vectors of vectors of tuples to Makie (if that doesn't work now, it can be made to work before Makie v0.21). |
The text was updated successfully, but these errors were encountered: