Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FeatureCollection and Feature wrappers are not fleshed out #122

Open
asinghvi17 opened this issue Apr 1, 2024 · 1 comment
Open

FeatureCollection and Feature wrappers are not fleshed out #122

asinghvi17 opened this issue Apr 1, 2024 · 1 comment

Comments

@asinghvi17
Copy link
Member

For example, it's pretty hard to actually get features out of a Wrappers.FeatureCollection. You have to monkey around a bit, and access fc.parent[i].parent.$feature_name.

It would be nice to let FeatureCollections subscribe to the Tables.jl interface and let Feature objects be getproperty'ed.

What do people here think? It could even be an extension on Tables.jl so as to not add a dependency.

@rafaqz
Copy link
Member

rafaqz commented May 19, 2024

The idea is to use feature = GI.getfeature(fc, i) and GI.geometry(feature)/GI.properties(feature).

Best to never access fields so that eg. a GeoJSON.jl Feature will also work with the same code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants