-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enforce coordinate eltype #53
Comments
I think it should be I will put this into the documentation, so any enforcement is not a breaking change later on. I'm also not sure how enforcement would look like or we want to specify an |
This is already in the documentation itself: I clarified it in the docstring as well:
|
Yeah indeed I think just documenting it might be enough, rather than "enforcing". Of course some operations may only make sense on AbstractFloat coordinates, but that is up to the implementer. |
@rafaqz brought up the point to change |
Do we currently expect anything from the coordinate eltype? Was SF always Float64? What do we do,
<:Real
,<:AbstractFloat
, or leave it open?The text was updated successfully, but these errors were encountered: