Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NED coordinates #69

Open
jleny opened this issue Mar 18, 2021 · 3 comments
Open

NED coordinates #69

jleny opened this issue Mar 18, 2021 · 3 comments

Comments

@jleny
Copy link

jleny commented Mar 18, 2021

Hi,

Would it make sense to add NED to this package in addition to ENU? North East Down is a more standard convention in aerospace engineering and that would make interfacing with some other projects smoother.

@c42f
Copy link
Member

c42f commented Mar 19, 2021

Technically this should be quite easy - you could add a NED type and NEDfromENU / ENUfromNED as simple permutations / sign change relative to ENU, and then all the other transformations would automatically be possible via composition. (some compositions could optionally be predefined for convenience)

I don't exactly love the proliferation of different coordinate types we have in this package but I also don't want to get too hung up on that. Do you think there's value in distinguishing between ENU and NED at the type level for your use cases?

@jleny
Copy link
Author

jleny commented Mar 19, 2021

Matlab's mapping toolbox has NED in addition to ENU, whereas the aerospace toolbox only seems to mention NED. I work on navigation systems, where NED is almost universally used over ENU.

There is no fundamental issue with implementing a NED type in higher-level applications every time it is needed, but I feel it would be more natural to have it here at the coordinate system level, on equal footing with ENU.

I was initially thinking of just duplicating all the ENU code, but indeed this could be done via composition if you prefer. If you want I can take a shot at it when I find some time.

@andyferris
Copy link
Contributor

If you want I can take a shot at it when I find some time.

Yes, that would be great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants