Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test with EvilArrays #130

Open
asinghvi17 opened this issue Apr 26, 2024 · 0 comments
Open

Test with EvilArrays #130

asinghvi17 opened this issue Apr 26, 2024 · 0 comments
Labels
good first issue Good for newcomers low priority Low priority issue, someone can get to it whenever they feel like it!

Comments

@asinghvi17
Copy link
Member

asinghvi17 commented Apr 26, 2024 •
edited
Loading

https://github.com/cmcaine/EvilArrays.jl should help us check that everything is using the GI API appropriately, and not doing any linear indexing. This is specifically a test for both GeoInterface wrapper geometry and GeometryOps algorithms.

This could be done by creating GI wrapper geometries backed by EvilArrays of points, and then running them through the GO algorithms to test whether any direct indexing is being done (instead of things like GI.x, GI.getgeom or GI.getpoint).
@asinghvi17 asinghvi17 added good first issue Good for newcomers low priority Low priority issue, someone can get to it whenever they feel like it! labels Apr 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers low priority Low priority issue, someone can get to it whenever they feel like it!
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@asinghvi17