Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Most of the Edit this page links in docs are broken #174

Open
DanielVandH opened this issue Jul 12, 2024 · 1 comment
Open

Most of the Edit this page links in docs are broken #174

DanielVandH opened this issue Jul 12, 2024 · 1 comment

Comments

@DanielVandH
Copy link
Contributor

e.g. on this page https://juliageo.org/GeometryOps.jl/v0.1.10/source/methods/clipping/intersection "Edit this page" sends you to a missing file. Presumably something is incorrect in

function _add_meta_edit_link_generator(path)
return function (input)
return """
```@meta
EditURL = "$(path).jl"
```
""" * input # we add `.jl` because `relpath` eats the file extension, apparently :shrug:
end
end

(assuming that's what generates the EditURL? I've had similar annoyances with EditURL in the past).

@asinghvi17
Copy link
Member

This is a DocumenterVitepress issue, since the Vitepress engine doesn't allow per-page edit links. Will have to look into it a bit more but we may have to roll and "Edit this page..." button ourselves.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants