Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename linear manifold to Euclidean? #222

Closed
tiemvanderdeure opened this issue Oct 4, 2024 · 4 comments
Closed

rename linear manifold to Euclidean? #222

tiemvanderdeure opened this issue Oct 4, 2024 · 4 comments

Comments

@tiemvanderdeure
Copy link
Contributor

I'm not a mathematician and a little out of my depth here, but the name Linear seems unintuitive to me for calculations in Euclidean space. Why don't we call it Euclidean? Linear sounds kind of 1D. If we want to specify that it is 2D space we could call it Planar, but I don't think that we do?

"""
Linear()
A linear manifold means that the space is completely Euclidean,
and planar geometry suffices.
"""
struct Linear <: Manifold
end

Manifolds.jl also calls their manifold in euclidean space Euclidean: https://juliamanifolds.github.io/Manifolds.jl/latest/manifolds/euclidean.html

@rafaqz
Copy link
Member

rafaqz commented Oct 4, 2024

I was also confused about what Linear meant, +1 for Euclidean

@asinghvi17
Copy link
Member

I would be fine with either Planar or Euclidean, but I feel like Planar is a bit more descriptive about what is actually going on?

@rafaqz
Copy link
Member

rafaqz commented Oct 4, 2024

I guess those methods will always be 2d?

@asinghvi17
Copy link
Member

asinghvi17 commented Oct 4, 2024

Most likely, if we go into 3d we can always soft-deprecate Planar for Euclidean

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants