Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plotting polygons with CairoMakie shows interior lines #104

Closed
tiemvanderdeure opened this issue Jan 31, 2024 · 3 comments
Closed

Plotting polygons with CairoMakie shows interior lines #104

tiemvanderdeure opened this issue Jan 31, 2024 · 3 comments

Comments

@tiemvanderdeure
Copy link

When plotting a polygon using CairoMakie, some vertices/lines appear within the polygon.

I don't have the same problem with GLMakie and it also only seems to affect Shapefile-polygons (I tried GeometryBasics and had no problems).

To reproduce (see attached .zip for the shape, which is from the NaturalEarth dataset):

using Shapefile, CairoMakie
taz = Shapefile.Table("tanzania/tanzania.shp").geometry[1]
f_cairo = CairoMakie.poly(taz)

using GLMakie
f_gl = GLMakie.poly(taz)

tanzania_cairo
tanzania_gl

tanzania.zip

@SimonDanisch
Copy link
Contributor

I noticed this too... Didn't have time to debug it though. Maybe @jkrumbiegel has an idea?

@jkrumbiegel
Copy link

Haha why do these keep happening 😄 Simon maybe you have to take a look at the override mechanism I am using for polygons in CairoMakie. This happens whenever some type does not hit the override methods and falls back to mesh drawing. Maybe the dispatch structure needs to be more generic so that I don't have to add every single possible type

@asinghvi17
Copy link
Member

Should be fixed in latest CairoMakie.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants