Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Myrs should be Myr #243

Closed
Iddingsite opened this issue Jan 22, 2025 · 3 comments
Closed

Myrs should be Myr #243

Iddingsite opened this issue Jan 22, 2025 · 3 comments

Comments

@Iddingsite
Copy link
Collaborator

Iddingsite commented Jan 22, 2025

I believe Myrs as a unit should be replaced by Myr, which is the commonly used abbreviation (see for instance https://en.wikipedia.org/wiki/Million_years_ago), which caused me some confusion the first time. All the other units are using conventional abbreviations and I think it would be nice to be consistent there.

That's something very easy to fix in the code but it would be a breaking change as it is part of the exposed API, so I don't know if that is a change you want to do now, but for me it should be ultimately corrected.

@boriskaus
Copy link
Member

I'm fine with deprecating Myrs. Perhaps introduce Myr and put a depreciation warning for some time that this will be removed in the future. I believe there is a Julia command for that.

@luraess
Copy link
Contributor

luraess commented Jan 22, 2025

Yes it has

@Iddingsite
Copy link
Collaborator Author

Solved by #246.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants