This repository has been archived by the owner on Jul 22, 2024. It is now read-only.
Fix tests on 1.6 #565
Closed
Fix tests on 1.6 #565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems to need a little delay before checking `:active`.
Codecov Report
@@ Coverage Diff @@
## master #565 +/- ##
==========================================
+ Coverage 50.19% 50.23% +0.03%
==========================================
Files 32 32
Lines 2540 2540
==========================================
+ Hits 1275 1276 +1
+ Misses 1265 1264 -1
Continue to review full report at Codecov.
|
|
It doesn't seem to be always enough (did Julia get too fast? 😅). Good news is that this makes CI more happy, bad news is that CI failure is probably not related to #562? |
|
Yeah, it's weird. I suspect we can fix it by adding sufficient delay but that seems like the wrong way to go about it. Let's see what more knowledgeable folks say about #562 (comment) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems to need a little delay before checking
:active.