Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support Lux #372

Closed
CarloLucibello opened this issue Jan 30, 2024 · 3 comments
Closed

support Lux #372

CarloLucibello opened this issue Jan 30, 2024 · 3 comments

Comments

@CarloLucibello
Copy link
Member

This package is built on top of Flux.jl, but we could consider also supporting Lux.jl since it is being used in some part of the ecosystem. It is not clear if supporting both can be done without a lot of code duplication.

cc @avik-pal
@avik-pal
Copy link

The easiest way to do that would be to provide NNlib like primitives instead of defining (l::GCNConv)(....), etc.

@avik-pal avik-pal mentioned this issue Feb 1, 2024
Open
5 tasks
@CarloLucibello
Copy link
Member Author

I'm going to factor out a DL-framework agnostic GNNlib.jl package.

@CarloLucibello CarloLucibello mentioned this issue May 4, 2024
Merged
@CarloLucibello CarloLucibello mentioned this issue Jul 22, 2024
Closed
10 tasks
@CarloLucibello CarloLucibello changed the title Lux support? support Lux Jul 25, 2024
@CarloLucibello CarloLucibello mentioned this issue Jul 26, 2024
Merged
@CarloLucibello
Copy link
Member Author

closing in favor of more specific #461

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@CarloLucibello @avik-pal