Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes and more tests in remove_nodes function #424

Merged
merged 5 commits into from
Mar 21, 2024

Conversation

rbSparky
Copy link
Contributor

I tested a little more and there are some errors to be fixed, I will fix those here
I missed these in the last PR

I'll also add more tests to make sure all cases are covered

@rbSparky
Copy link
Contributor Author

needed to add these checks to check bounds

    function find_edges_to_remove(nodes, nodes_to_remove)
        return findall(node_id -> begin
            idx = searchsortedlast(nodes_to_remove, node_id)
            idx >= 1 && idx <= length(nodes_to_remove) && nodes_to_remove[idx] == node_id
        end, nodes)
    end

@CarloLucibello
Copy link
Member

You can add a test that was failing before this PR

@rbSparky
Copy link
Contributor Author

rbSparky commented Mar 17, 2024

You can add a test that was failing before this PR

Done, and made the fixes
Added the test that previously failed and the fixed code

rbSparky and others added 2 commits March 21, 2024 12:41
Co-authored-by: Carlo Lucibello <carlo.lucibello@gmail.com>
@CarloLucibello CarloLucibello merged commit 374d8fb into JuliaGraphs:master Mar 21, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants