Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix UndefVarError: zError not defined #107

Merged
merged 1 commit into from
Oct 4, 2023
Merged

Conversation

sunoru
Copy link
Contributor

@sunoru sunoru commented Sep 28, 2023

It is a small & obvious fix. zError is not exported by ZLib_h so the current version (after the refactor #101) will throw an UndefVarError whenever a zerror happens.

@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (039ee2a) 9.98% compared to head (dd32121) 9.98%.

Additional details and impacted files
@@          Coverage Diff           @@
##           master    #107   +/-   ##
======================================
  Coverage    9.98%   9.98%           
======================================
  Files          17      17           
  Lines        2374    2374           
======================================
  Hits          237     237           
  Misses       2137    2137           
Files Coverage Δ
src/zlib.jl 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sjkelly sjkelly merged commit c6f29bd into JuliaIO:master Oct 4, 2023
5 of 6 checks passed
@sjkelly
Copy link
Member

sjkelly commented Oct 4, 2023

Thanks!

@sunoru sunoru deleted the patch-1 branch October 4, 2023 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants