Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gzopen(): use Libc.errno() #108

Merged
merged 3 commits into from
Dec 2, 2023
Merged

gzopen(): use Libc.errno() #108

merged 3 commits into from
Dec 2, 2023

Conversation

alyst
Copy link
Contributor

@alyst alyst commented Nov 30, 2023

I was trying to open the non-existing file, which triggered /lib/x86_64-linux-gnu/libc.so: Incorrect ELF header.
When I replaced unsafe_load(cglobal((:errno, :libc), Cint)) with Libc.errno(), the issue got resolved, and I got the proper "Not such file or directory" error.

Fixes #106

@alyst
Copy link
Contributor Author

alyst commented Nov 30, 2023

CI failures don't look related

Copy link

codecov bot commented Dec 2, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e1206d5) 9.98% compared to head (559c9e8) 10.15%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #108      +/-   ##
==========================================
+ Coverage    9.98%   10.15%   +0.16%     
==========================================
  Files          17       17              
  Lines        2374     2374              
==========================================
+ Hits          237      241       +4     
+ Misses       2137     2133       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alyst
Copy link
Contributor Author

alyst commented Dec 2, 2023

@ViralBShah or @sjkelly, could you pls review the PR?

@sjkelly sjkelly merged commit 15407e2 into JuliaIO:master Dec 2, 2023
6 checks passed
@sjkelly
Copy link
Member

sjkelly commented Dec 2, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent error for file not found
2 participants