Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs build #1169

Closed
wants to merge 2 commits into from
Closed

Conversation

ajwheeler
Copy link

@ajwheeler ajwheeler commented Oct 16, 2024

This PR:

  • deletes test/Manifest.toml, which I think is being tracked by mistake
  • adds a compat entry for Documenter in the test Project.toml
  • tweaks docs/make.jl to work with the newest Documenter versions
  • Drops UNLIMITED and is_selection_valid from @docs blocks because they don't seem to be defined.
    • I don't understand what's going on with this one. I see them in the source, but they don't seem to be in the current docs, and I can't access them if I load the package myself.

edit: sorry for submitting something which fails, but I think this should be straightforward to fix for someone who understands what's going on with UNLIMITED and is_selection_valid.

@mkitti
Copy link
Member

mkitti commented Nov 14, 2024

Thank you for the help and the hints for how to fix things. I'm heading in a slightly different direction with the size_threshold for now.

See #1172

@mkitti mkitti closed this Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants