Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docs and tests #206

Merged
merged 2 commits into from
Nov 9, 2024
Merged

Fix docs and tests #206

merged 2 commits into from
Nov 9, 2024

Conversation

ViralBShah
Copy link
Contributor

@ViralBShah ViralBShah commented Nov 7, 2024

Copy link

codecov bot commented Nov 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.27%. Comparing base (6696375) to head (011c435).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #206   +/-   ##
=======================================
  Coverage   69.27%   69.27%           
=======================================
  Files           9        9           
  Lines         485      485           
=======================================
  Hits          336      336           
  Misses        149      149           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ViralBShah
Copy link
Contributor Author

@johnnychen94 @timholy I have disabled a few tests mainly due to formatting issues that I didn't yet get around to fixing. Also the Aqua stale_deps test was failing on BlockArrays and I couldn't figure out why so disabled that for now.

If you guys can help fix more of those, it will be nice. But I think even with these, it should be ok to tag this release, which will pave the way for the broad ecosystem upgrade to new versions.

@ViralBShah ViralBShah merged commit 22e4cd8 into master Nov 9, 2024
10 checks passed
@ViralBShah ViralBShah deleted the vs/fixtests branch November 9, 2024 03:33
@charleskawczynski
Copy link
Contributor

charleskawczynski commented Nov 12, 2024

Can we instead add Aqua and BlockArrays to a docs/testing environment, rather than adding it as a direct package dependency?

@ViralBShah
Copy link
Contributor Author

Good point. Can you make a PR if you dont mind?

@charleskawczynski
Copy link
Contributor

Opened #208, cc @ViralBShah. I think that may be all that's needed. If we just leave the compat entries there, will that still guide the test env?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants