Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't depend on ImageTransformation #27

Closed
johnnychen94 opened this issue Dec 19, 2019 · 1 comment
Closed

Don't depend on ImageTransformation #27

johnnychen94 opened this issue Dec 19, 2019 · 1 comment

Comments

@johnnychen94
Copy link
Member

johnnychen94 commented Dec 19, 2019

ImageTransformations.jl is used to resize large images into smaller ones, but since displaying images in the terminal already losses lots of information, we could implement a much simpler subsampling method for this. The advantage is that we can make this package smaller by removing it (e.g., SpecialFunctions as one binary artifact is required by ImageTransformations)

package loading time with/without ImageTranformations:

  • With: 5.043510 seconds (10.71 M allocations: 568.856 MiB, 2.16% gc time)
  • Without: 3.133149 seconds (7.04 M allocations: 369.394 MiB, 4.49% gc time)

If JuliaImages/ImageCore.jl#106 got merged, it's likely to get another 1.5s reduction.

cc: @oxinabox

@johnnychen94
Copy link
Member Author

closed by #54

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant