Proposal: Expand allowed paths for specifying sysimage #155
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for passing a custom system image path was added in #140, but it requires that the path be specified relative to
JULIA_HOME
. This might be overly restrictive as it prevents supplying absolute paths, and it is also complicated to supply paths relative to the current directly as would normally be done when starting Julia (i.e.julia -J path/to/sysimage
)This PR changes the handling of the path to match what is done in pyjulia, where you can pass either an absolute path to the image, or a relative path, in which case the path is interpreted as being relative to the current directory. This is also how Julia interprets arguments passed using
-J/--sysimage
.It is still easy to pass a path relative to
JULIA_HOME
by passingpaste(JULIA_HOME, relative_sysimage_path, sep = "/")
as was done automatically before.This is technically breaking, but I think is worthwhile as enables a lot more flexibility with passing paths, and it brings consistency with Julia and pyjulia. I also changed the argument name from
relative_sysimage_path
tosysimage_path
to improve clarity since it would no longer be restricted to relative paths.