Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix current_exceptions test on nightly #810

Merged
merged 1 commit into from
Nov 28, 2023
Merged

Conversation

martinholters
Copy link
Member

The printing of the UndefVarError now includes the originating module.

The printing of the `UndefVarError` now includes the originating module.
Copy link

codecov bot commented Nov 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d687917) 92.83% compared to head (5dd96a5) 92.83%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #810   +/-   ##
=======================================
  Coverage   92.83%   92.83%           
=======================================
  Files           2        2           
  Lines         335      335           
=======================================
  Hits          311      311           
  Misses         24       24           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martinholters
Copy link
Member Author

Tests on nightly still fail, but now due to JuliaLang/julia#52010, ref #804 (comment).

@martinholters martinholters merged commit db2077e into master Nov 28, 2023
17 of 20 checks passed
@martinholters martinholters deleted the mh/fix-exceptions-test branch November 28, 2023 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant