Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

arg_read_size doesn't understand GenericIOBuffer #142

Closed
c42f opened this issue Aug 24, 2021 · 2 comments · Fixed by #143
Closed

arg_read_size doesn't understand GenericIOBuffer #142

c42f opened this issue Aug 24, 2021 · 2 comments · Fixed by #143

Comments

@c42f
Copy link
Member

c42f commented Aug 24, 2021

Through a weird series of events, I've discovered that

Downloads.arg_read_size(IOBuffer(codeunits("hi"))) === nothing

(This causes us not to call set_upload_size(), which in turn causes libcurl to set Transfer-Encoding: chunked, which in turn causes PutObject to S3 to fail when input is of type Base.GenericIOBuffer{Base.CodeUnits{UInt8, String}}.

I guess we should define arg_read_size(::GenericIOBuffer)?

@StefanKarpinski
Copy link
Member

For IOBuffer, do we know how big the upload will be? Calling io.size seems too low level.

@c42f
Copy link
Member Author

c42f commented Aug 26, 2021

I looked this up. It looks like bytesavailable is the correct function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants