Skip to content
This repository has been archived by the owner on Jun 9, 2023. It is now read-only.

0.4 failure (in defining parse function) #18

Closed
stevengj opened this issue Mar 27, 2015 · 3 comments
Closed

0.4 failure (in defining parse function) #18

stevengj opened this issue Mar 27, 2015 · 3 comments

Comments

@stevengj
Copy link
Member

With 0.4, this is now giving:

ERROR: LoadError: error in method definition: function Base.parse must be explicitly imported to be extended
 in include at ./boot.jl:250
 in include_from_node1 at ./loading.jl:129
 in include at ./boot.jl:250
 in include_from_node1 at ./loading.jl:129
 in reload_path at ./loading.jl:153
 in _require at ./loading.jl:68
 in require at ./loading.jl:51
 in include at ./boot.jl:250
 in include_from_node1 at ./loading.jl:129
while loading /Users/stevenj/.julia/JuliaParser/src/parser.jl, in expression starting on line 1864
while loading /Users/stevenj/.julia/JuliaParser/src/JuliaParser.jl, in expression starting on line 6
while loading /Users/stevenj/.julia/JuliaParser/test/runtests.jl, in expression starting on line 1

Frankly, I don't understand the source of this issue. Isn't it valid to define a JuliaParser.parse function that shadows Base.parse without extending it? (After all, this error about importing before extending was added in 2012: JuliaLang/julia@289c6df.)

Presumably, something has recently changed about Base.parse that suddenly makes Julia interpret the JuliaParser.parse as an extension of the same function rather than as a declaration of a new function in the JuliaParser namespace? (The issue is not that JuliaParser/src/parser.jl does export parse, since I get the same error if I comment out that line.)

@JeffBezanson, @vtjnash?

@stevengj
Copy link
Member Author

Note that this is apparently causing Coverage to fail, which is cascading into a lot of Travis failures on other projects that weren't using after_success: before their coverage line in .travis.yml.

@staticfloat
Copy link
Member

Yep, I can confirm the same thing killing the buildbot Base coverage tests.

@jakebolewski
Copy link
Member

Fixed by JuliaLang/julia@3d37c86.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants