Skip to content
This repository has been archived by the owner on Jun 9, 2023. It is now read-only.

Update for recent parser changes. #19

Closed
yuyichao opened this issue Jul 28, 2015 · 8 comments
Closed

Update for recent parser changes. #19

yuyichao opened this issue Jul 28, 2015 · 8 comments

Comments

@yuyichao
Copy link
Contributor

There has been some changes to the julia parser and this packages seems to be not in sync anymore. Apart from the doc string changes, there are three of my PR's that relaxes some of the restrictions for parsing. JuliaLang/julia#11345, JuliaLang/julia#11338, JuliaLang/julia#11333.

In particular, the new syntax allowed by JuliaLang/julia#11333 seems to be causing JuliaCI/Coverage.jl#77

@kshyatt

@jrevels
Copy link
Member

jrevels commented Aug 6, 2015

I can take a crack at fixing the breakage caused by JuliaLang/julia#11333 today. If I'm not misunderstanding, I just need to make this function consistent with the logic applied here, yes?

@yuyichao
Copy link
Contributor Author

yuyichao commented Aug 6, 2015

Should be. Also make sure it passes these tests yuyichao/julia@b2c2d42

@Keno
Copy link
Member

Keno commented Jan 19, 2016

I updated this package such that is passes all it's current tests. If you write new ones for these parser changes, I can fix them as well.

@tkelman
Copy link
Contributor

tkelman commented Jan 19, 2016

FactCheck finished with 51 non-successful tests.

@Keno
Copy link
Member

Keno commented Jan 19, 2016

You're always so negative! I was discounting JuliaLang/julia#14658

@tkelman
Copy link
Contributor

tkelman commented Jan 20, 2016

Forgot about that one, sorry. We have new nightlies now, if that makes a difference. Still best to do something about the tests on release julia before we consider tagging this again though.

@Keno
Copy link
Member

Keno commented Apr 1, 2016

Done.

@Keno Keno closed this as completed Apr 1, 2016
@yuyichao
Copy link
Contributor Author

yuyichao commented Apr 1, 2016

=) 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants