This repository has been archived by the owner on Jun 9, 2023. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 39
Update for recent parser changes. #19
Comments
This was referenced Aug 1, 2015
I can take a crack at fixing the breakage caused by JuliaLang/julia#11333 today. If I'm not misunderstanding, I just need to make this function consistent with the logic applied here, yes? |
Should be. Also make sure it passes these tests yuyichao/julia@b2c2d42 |
I updated this package such that is passes all it's current tests. If you write new ones for these parser changes, I can fix them as well. |
|
You're always so negative! I was discounting JuliaLang/julia#14658 |
Forgot about that one, sorry. We have new nightlies now, if that makes a difference. Still best to do something about the tests on release julia before we consider tagging this again though. |
Done. |
=) 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
There has been some changes to the julia parser and this packages seems to be not in sync anymore. Apart from the doc string changes, there are three of my PR's that relaxes some of the restrictions for parsing. JuliaLang/julia#11345, JuliaLang/julia#11338, JuliaLang/julia#11333.
In particular, the new syntax allowed by JuliaLang/julia#11333 seems to be causing JuliaCI/Coverage.jl#77
@kshyatt
The text was updated successfully, but these errors were encountered: