-
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
logabsdet
has a weird name
#1026
Comments
The name seems fine to me. It does return the log of the absolute value of the determinant; it just returns the sign too if you want it. SAS calls it It's been around for quite some time in Julia (#13) and hasn't seemed particularly problematic or controversial. It seems past the time for bikeshedding the name. |
If it's common in other languages that seems fine to me.
Allowing multiple names is not a breaking change. |
...nor is it a good design. |
We don't seem likely to do this, so closing as not planned. |
It's not a bug per se, but
logabsdet
's name makes it sound like it's supposed to return the log-absolute value of the determinant. Would it make sense to create alog_det_sign
orlog_det_parity
function and then document that it should be preferred tologabsdet
?The text was updated successfully, but these errors were encountered: