Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sparse polyalgorithm seems to have a glitch #158

Closed
ViralBShah opened this issue Jan 5, 2015 · 2 comments
Closed

Sparse polyalgorithm seems to have a glitch #158

ViralBShah opened this issue Jan 5, 2015 · 2 comments
Labels
performance Must go faster sparse Sparse arrays

Comments

@ViralBShah
Copy link
Member

As discussed here:

https://groups.google.com/forum/#!topic/julia-users/FagaqWVkBGU

Our sparse polyalgorithm is doing something wrong.

@ViralBShah ViralBShah added sparse Sparse arrays linear algebra performance Must go faster labels Jan 5, 2015
@ViralBShah
Copy link
Member Author

Currently, factorize(S::SparseMatrixCSC) does the following (bottom of cholmod.jl), which is too simplistic.

# placing factorize here for now. Maybe add a new file
function factorize(A::SparseMatrixCSC)
    m, n = size(A)
    if m == n
        Ac = cholfact(A)
        Ac.c.minor == m && ishermitian(A) && return Ac
    end
    return lufact(A)
end

Instead, we should be doing as Tim Davis suggested in the thread on the mailing list:
http://faculty.cse.tamu.edu/davis/publications_files/Factorize_an_object_oriented_linear_system_solver_for_MATLAB.pdf

@ViralBShah
Copy link
Member Author

#16 is the same thing.

@KristofferC KristofferC transferred this issue from JuliaLang/julia Nov 26, 2024
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance Must go faster sparse Sparse arrays
Projects
None yet
Development

No branches or pull requests

1 participant