Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

full broken for LU{Tridiagonal} via missing getindex(::LU{Tridiagonal}, ::Symbol) #215

Closed
timholy opened this issue May 16, 2015 · 2 comments · Fixed by JuliaLang/julia#12137

Comments

@timholy
Copy link
Member

timholy commented May 16, 2015

julia> A = Tridiagonal(-rand(4),rand(5)+2, -rand(4))
5x5 Base.LinAlg.Tridiagonal{Float64}:
  2.21797   -0.494058   0.0        0.0        0.0     
 -0.571447   2.98739   -0.434064   0.0        0.0     
  0.0       -0.790323   2.56      -0.123797   0.0     
  0.0        0.0       -0.451037   2.6055    -0.418696
  0.0        0.0        0.0       -0.120847   2.47719 

julia> F = lufact(A)
Base.LinAlg.LU{Float64,Base.LinAlg.Tridiagonal{Float64}}(5x5 Base.LinAlg.Tridiagonal{Float64}:
  2.21797   -0.494058   0.0        0.0         0.0     
 -0.257644   2.8601    -0.434064   0.0         0.0     
  0.0       -0.276327   2.44006   -0.123797    0.0     
  0.0        0.0       -0.184847   2.58262    -0.418696
  0.0        0.0        0.0       -0.0467926   2.4576  ,[1,2,3,4,5],0)

julia> full(F)
ERROR: MethodError: `getindex` has no method matching getindex(::Base.LinAlg.LU{Float64,Base.LinAlg.Tridiagonal{Float64}}, ::Symbol)
 in full at linalg/lu.jl:358
@timholy
Copy link
Member Author

timholy commented May 16, 2015

In this case, would it be reasonable to implement full directly? (Until we get JuliaLang/julia#8240, that would certainly be easier.)

@tkelman
Copy link

tkelman commented May 16, 2015

would it be reasonable to implement full directly?

Makes sense to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants