From 0aab0dc8ee49a893a14f6ea8f7f555c0a6816c7a Mon Sep 17 00:00:00 2001 From: Tim Holy Date: Sun, 25 Jul 2021 11:43:20 -0500 Subject: [PATCH] Apply suggestions from code review Co-authored-by: Jameson Nash --- stdlib/REPL/src/REPL.jl | 2 +- stdlib/REPL/src/REPLCompletions.jl | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/stdlib/REPL/src/REPL.jl b/stdlib/REPL/src/REPL.jl index 6478b03a98273..8f67384d698d1 100644 --- a/stdlib/REPL/src/REPL.jl +++ b/stdlib/REPL/src/REPL.jl @@ -472,7 +472,7 @@ LineEditREPL(t::TextTerminal, hascolor::Bool, envcolors::Bool=false) = ) mutable struct REPLCompletionProvider <: CompletionProvider - modifier::Symbol + shift::Bool end REPLCompletionProvider() = REPLCompletionProvider(:none) mutable struct ShellCompletionProvider <: CompletionProvider end diff --git a/stdlib/REPL/src/REPLCompletions.jl b/stdlib/REPL/src/REPLCompletions.jl index 1a945f482ccec..dd765f0a2da72 100644 --- a/stdlib/REPL/src/REPLCompletions.jl +++ b/stdlib/REPL/src/REPLCompletions.jl @@ -504,16 +504,16 @@ function complete_any_methods(ex_org::Expr, callee_module::Module, context_modul end for name in names(callee_module; all=true) - if isdefined(callee_module, name) + if !isdeprecated(callee_module, name) && isdefined(callee_module, name) func = getfield(callee_module, name) - if isa(func, Base.Callable) && func !== Vararg + if !isa(func, Module) complete_methods!(out, func, args_ex, kwargs_ex, moreargs) elseif callee_module === Main::Module && isa(func, Module) callee_module2 = func for name in names(callee_module2) if isdefined(callee_module2, name) func = getfield(callee_module, name) - if isa(func, Base.Callable) && func !== Vararg + if isa(func, Base.Callable) complete_methods!(out, func, args_ex, kwargs_ex, moreargs) end end