From 39879b7144f7ae1c72fa378ac873e58005f539f8 Mon Sep 17 00:00:00 2001
From: d-netto <diogonetto.dcn@gmail.com>
Date: Mon, 17 Jul 2023 21:41:43 -0300
Subject: [PATCH] suggestion from Gabriel's review

---
 src/gc.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/src/gc.c b/src/gc.c
index 7f8c046de23d1..ec6d6b42cc71e 100644
--- a/src/gc.c
+++ b/src/gc.c
@@ -813,6 +813,10 @@ FORCE_INLINE int gc_try_setmark_tag(jl_taggedvalue_t *o, uint8_t mark_mode) JL_N
         tag = tag | mark_mode;
         assert((tag & 0x3) == mark_mode);
     }
+    // XXX: note that marking not only sets the GC bits but also updates the
+    // page metadata for pool allocated objects.
+    // The second step is **not** idempotent, so we need a compare exchange here
+    // (instead of a pair of load&store) to avoid marking an object twice
     tag = jl_atomic_exchange_relaxed((_Atomic(uintptr_t)*)&o->header, tag);
     verify_val(jl_valueof(o));
     return !gc_marked(tag);