From 41f07acf22349d7257acce4fc91aa4140e624a42 Mon Sep 17 00:00:00 2001 From: Kristoffer Carlsson Date: Thu, 20 Feb 2020 21:55:25 +0100 Subject: [PATCH] remove error when calling fieldtype on a Module (#34804) --- src/builtins.c | 2 -- test/misc.jl | 4 ++++ 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/src/builtins.c b/src/builtins.c index 8f7133adfb3e4..9039e579e03dc 100644 --- a/src/builtins.c +++ b/src/builtins.c @@ -885,8 +885,6 @@ JL_CALLABLE(jl_f_fieldtype) } JL_NARGS(fieldtype, 2, 2); jl_datatype_t *st = (jl_datatype_t*)args[0]; - if (st == jl_module_type) - jl_error("cannot assign variables in other modules"); return get_fieldtype(args[0], args[1], 1); } diff --git a/test/misc.jl b/test/misc.jl index 00e44099f6d2f..1d096b2828de2 100644 --- a/test/misc.jl +++ b/test/misc.jl @@ -804,3 +804,7 @@ end GC.safepoint() end + +@testset "fieldtypes Module" begin + @test fieldtypes(Module) isa Tuple +end