Skip to content

Commit

Permalink
add note on windows ACL problems
Browse files Browse the repository at this point in the history
  • Loading branch information
fatteneder committed Feb 20, 2024
1 parent 4f20a42 commit c31f1ee
Showing 1 changed file with 12 additions and 2 deletions.
14 changes: 12 additions & 2 deletions base/sysinfo.jl
Original file line number Diff line number Diff line change
Expand Up @@ -568,6 +568,8 @@ Return `true` if the given `path` has executable permissions.
ACLs on Windows, therefore it would return `true` for any
file. From Julia 1.6 on, it correctly determines whether the
file is marked as executable or not.
See also [`ispath`](@ref), [`isreadable`](@ref), [`iswriteable`](@ref).
"""
function isexecutable(path::String)
# We use `access()` and `X_OK` to determine if a given path is
Expand All @@ -587,10 +589,14 @@ Return `true` if the access permissions for the given `path` permitted reading b
so it is recommended to just call `open` alone and handle the error if that fails,
rather than calling `isreadable` first.
!!! note
Currently this function does not correctly interrogate filesystem
ACLs on Windows, therefore it can return wrong results.
!!! compat "Julia 1.11"
This function requires at least Julia 1.11.
See also [`ispath`](@ref).
See also [`ispath`](@ref), [`isexecutable`](@ref), [`iswriteable`](@ref).
"""
function isreadable(path::String)
# We use `access()` and `R_OK` to determine if a given path is
Expand All @@ -610,10 +616,14 @@ Return `true` if the access permissions for the given `path` permitted writing b
so it is recommended to just call `open` alone and handle the error if that fails,
rather than calling `iswriteable` first.
!!! note
Currently this function does not correctly interrogate filesystem
ACLs on Windows, therefore it can return wrong results.
!!! compat "Julia 1.11"
This function requires at least Julia 1.11.
See also [`ispath`](@ref).
See also [`ispath`](@ref), [`isexecutable`](@ref), [`isreadable`](@ref).
"""
function iswriteable(path::String)
# We use `access()` and `W_OK` to determine if a given path is
Expand Down

0 comments on commit c31f1ee

Please sign in to comment.