Package system on libgit2 #11196

wildart · 2015-05-08T05:57:03Z

Package system switch to libgit2 promises faster and resource efficient package management.

This work originated in #11143.

Pending:

next libgit2 release, tracking issue here (will provide support for HTTPS on Windows sans OpenSSL)
homebrew update for libgit2 0.23

IainNZ · 2015-05-09T15:52:52Z

This is heroic stuff

nalimilan · 2015-05-10T09:26:33Z

base/pkg/libgit2/const.jl

@@ -0,0 +1,210 @@
+module GitConst
+
+    const OBJ_ANY    = Cint(-2)


Wouldn't it make sense to use enums here now that they are supported?

tkelman · 2015-05-16T10:01:51Z

You're doing a kickass job in here, btw.

ViralBShah · 2015-05-16T10:28:30Z

This is fantastic. I wonder the likelihood of having this go into 0.4.

hayd · 2015-05-16T11:01:17Z

base/pkg/cache.jl

+        try
+            LibGit2.GitRepo(cache) # open repo, free it at the end
+        catch err
+            rethrow(err)


Does this catch block do anything?

Exactly. 👍

Funny answer for a question. :-p

wildart · 2015-05-16T15:44:30Z

@ViralBShah That was an idea, but it depends on 0.4 release date. At this point, there are few places left to convert. I didn't expect that libgit2 would be such a present. I count for another week to finish rewrite. After all, this thing would require some thorough testing.

tkelman · 2015-05-16T18:21:52Z

We're still on -dev for a little while longer, but probably not too much. If you can get this fully working on all platforms in the next few weeks, then we should think about switching. I'll need a few days to do some surgery to take command-line git out of the Windows binaries (and similar but not quite as invasive for the Mac binaries), if we're going to be ambitious enough for a complete replacement.

We could possibly merge a conservative version of this for 0.4 that leaves both command-line git and libgit2 simultaneously around, and only uses libgit2 for the parts of Pkg where you feel it will work robustly.

wildart · 2015-05-16T18:27:49Z

@tkelman I do not have access to OSX. Help appreciated.

tkelman · 2015-05-16T19:42:35Z

Neither do I. I can help you tweak appveyor to run the pkg test when you think it's ready for that, for now it isn't building this PR since it's apparently un-mergeable, but that's probably for the best at the moment.

tkelman · 2015-05-16T19:43:37Z

It'll probably still time out, but may as well uncomment this line

julia/.travis.yml

Line 4 in 713e9e5

    
           #- osx # this build is running out of time frequently now, disable it until we can make the tests it runs faster / fewer

to get this PR testing on OSX

tkelman · 2015-05-19T08:25:07Z

There was some broken homebrew stuff on OSX Travis that I fixed, and it looks like this passes! Worth rebasing, and tweaking appveyor now you think?

Also good to add the new license header style on any newly added files

ViralBShah · 2015-05-19T09:26:47Z

I am happy to test on OS X, and I am sure so will @StefanKarpinski

jakebolewski · 2015-09-29T23:16:05Z

Thanks @wildart for being persistent and addressing all our points over these past months!

Package system on libgit2

vtjnash · 2015-09-30T00:23:33Z

this looks truly monumental. i'm excited!

jiahao · 2015-09-30T00:28:23Z

🍰

StefanKarpinski · 2015-09-30T00:49:08Z

Oh sweet! This is really exciting.

tkelman · 2015-09-30T04:44:19Z

Note that we'll probably have to split up any libgit2 tests that rely on internet connectivity, put them either in pkg or a new file that doesn't run by default (since distro buildbots don't have internet connectivity) but we manually add to travis and appveyor.

wildart · 2015-09-30T05:51:00Z

What's happened? I was thinking about how to spit Pkg before merging and ... I guess it's for the best cause this PR has become so bloated I have a hard time tracking issues.

Thanks everybody for reviewing. @tkelman You've been a great help.

tomasaschan · 2015-09-30T07:31:31Z

Great work, everyone involved! I'm really looking forward to using this! :)

KristofferC · 2015-09-30T08:04:58Z

ScottPJones · 2015-09-30T11:39:23Z

@wildart How will this be split, technically? Will you put generic function definitions in Base, i.e.
function name end
and then via a "using PkgDev" add the actual methods for those (but they'd still be accessible as:
Pkg.blahblahblah?
I think that approach might be nicer than having to do PkgDev.blahblahblah, and remember which things are in Base, and which are extensions.

wildart · 2015-09-30T12:18:31Z

Definitely PkgDev, no monkey business with Base.

ScottPJones · 2015-09-30T17:46:55Z

Is it really monkey business to put generic definitions (which were added late in 0.4) for all the functions?
It seems like a nice technique that could be used in a lot of places where "advanced" stuff is planned to be moved out of Base in the future.

jakebolewski · 2015-09-30T17:49:21Z

You can import Base.Pkg into PkgDev and then re-export the methods, that way PkgDev becomes a strict superset in functionality (no cognitive burden required).

ScottPJones · 2015-09-30T17:51:13Z

But then you still have both Pkg and PkgDev, and only some methods are available in Pkg.
That seems like a bother to me.

wildart · 2015-09-30T18:28:01Z

The whole idea of PkgDev is separating a development functionality from Pkg which should target user experience only. No harm in typing 3 more letters.

hayd · 2015-09-30T18:53:15Z

Also #5155.

tkelman · 2015-11-12T03:50:10Z

@wildart did you ever get a chance to structure the Git REPL mode as a package? A few people have expressed interest in using it, would be cool to have available to try out somewhere.

wildart mentioned this pull request May 8, 2015

WIP: Pkg on libgit2 #11143

Closed

tkelman added the packages Package management and loading label May 8, 2015

nalimilan reviewed May 10, 2015
View reviewed changes

tkelman mentioned this pull request May 14, 2015

Pkg: store results of Pkg.build and behave more intuitively on broken packages #11262

Closed

hayd reviewed May 16, 2015
View reviewed changes

tkelman mentioned this pull request May 16, 2015

libgit2 planning issue #7584

Closed

wildart force-pushed the art/pkg-libgit2 branch 4 times, most recently from dd8f3bf to c6612f1 Compare May 18, 2015 03:58

wildart force-pushed the art/pkg-libgit2 branch from da0f43d to 10129bd Compare May 19, 2015 23:30

wildart and others added 3 commits September 29, 2015 14:59

renamed module GitConst to Consts, added support of ssh-agent

509e4b2

returned Pkg.Git module

11f08b5

fix deprecation warning

d18efae

jakebolewski force-pushed the art/pkg-libgit2 branch from 6597b06 to be39e2c Compare September 29, 2015 19:42

add error branch test for package availablity

35cd85f

jakebolewski force-pushed the art/pkg-libgit2 branch from be39e2c to 35cd85f Compare September 29, 2015 20:29

jakebolewski added a commit that referenced this pull request Sep 29, 2015

Merge pull request #11196 from JuliaLang/art/pkg-libgit2

43e7ff1

Package system on libgit2

jakebolewski merged commit 43e7ff1 into master Sep 29, 2015

hayd deleted the art/pkg-libgit2 branch September 29, 2015 23:19

tomasaschan mentioned this pull request Oct 2, 2015

Allow manual override of return type for fillvalue JuliaMath/Interpolations.jl#72

Merged

This was referenced Oct 2, 2015

Document dependency on libssl when compiling Julia from source #13389

Closed

libcurl problems with libgit2 on master #13472

Closed

rfourquet mentioned this pull request Nov 28, 2017

unmerge Base.merge! and LibGit2.merge! #24818

Merged

stevengj mentioned this pull request Nov 16, 2020

@which macro broken hyperlink for non base methods #37697

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Package system on libgit2 #11196

Package system on libgit2 #11196

wildart commented May 8, 2015

IainNZ commented May 9, 2015

nalimilan May 10, 2015

tkelman commented May 16, 2015

ViralBShah commented May 16, 2015

hayd May 16, 2015

wildart May 16, 2015

nalimilan May 16, 2015

wildart commented May 16, 2015

tkelman commented May 16, 2015

wildart commented May 16, 2015

tkelman commented May 16, 2015

tkelman commented May 16, 2015

tkelman commented May 19, 2015

ViralBShah commented May 19, 2015

jakebolewski commented Sep 29, 2015

vtjnash commented Sep 30, 2015

jiahao commented Sep 30, 2015

StefanKarpinski commented Sep 30, 2015

tkelman commented Sep 30, 2015

wildart commented Sep 30, 2015

tomasaschan commented Sep 30, 2015

KristofferC commented Sep 30, 2015

ScottPJones commented Sep 30, 2015

wildart commented Sep 30, 2015

ScottPJones commented Sep 30, 2015

jakebolewski commented Sep 30, 2015

ScottPJones commented Sep 30, 2015

wildart commented Sep 30, 2015

hayd commented Sep 30, 2015

tkelman commented Nov 12, 2015

Package system on libgit2 #11196

Package system on libgit2 #11196

Conversation

wildart commented May 8, 2015

IainNZ commented May 9, 2015

nalimilan May 10, 2015

Choose a reason for hiding this comment

tkelman commented May 16, 2015

ViralBShah commented May 16, 2015

hayd May 16, 2015

Choose a reason for hiding this comment

wildart May 16, 2015

Choose a reason for hiding this comment

nalimilan May 16, 2015

Choose a reason for hiding this comment

wildart commented May 16, 2015

tkelman commented May 16, 2015

wildart commented May 16, 2015

tkelman commented May 16, 2015

tkelman commented May 16, 2015

tkelman commented May 19, 2015

ViralBShah commented May 19, 2015

jakebolewski commented Sep 29, 2015

vtjnash commented Sep 30, 2015

jiahao commented Sep 30, 2015

StefanKarpinski commented Sep 30, 2015

tkelman commented Sep 30, 2015

wildart commented Sep 30, 2015

tomasaschan commented Sep 30, 2015

KristofferC commented Sep 30, 2015

ScottPJones commented Sep 30, 2015

wildart commented Sep 30, 2015

ScottPJones commented Sep 30, 2015

jakebolewski commented Sep 30, 2015

ScottPJones commented Sep 30, 2015

wildart commented Sep 30, 2015

hayd commented Sep 30, 2015

tkelman commented Nov 12, 2015