Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Matrix API: Why is it issym, but ishermitian ? #15182

Closed
pkofod opened this issue Feb 22, 2016 · 4 comments
Closed

Matrix API: Why is it issym, but ishermitian ? #15182

pkofod opened this issue Feb 22, 2016 · 4 comments

Comments

@pkofod
Copy link
Contributor

pkofod commented Feb 22, 2016

Is there any reason for the function name issym instead of issymmetric when it is not isher but ishermitian?

@KristofferC
Copy link
Member

Matlab also uses issymmetric

@andreasnoack
Copy link
Member

0691bc1, but I couldn't find a discussion. I don't really like abbreviations, so I wouldn't mind issymmetric.

@StefanKarpinski
Copy link
Member

+1 – issym has the potential to be confused with "is symbol", which is a silly function to have, but still.

@pkofod
Copy link
Contributor Author

pkofod commented Feb 22, 2016

Exactly, how can you know (ignoring context) if issym is issymmetric or issymbol? I'll track down the uses of issym, make a PR with issymmetric and deprecate issym. Then we can see which one people prefer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants