libgit2 and ssh keys - regression in 0.5.0-rc0 compared to 0.4.0

[mdcfrancis]

This is a regression on 0.5.0-rc0 with a local git repo using SSH, this is using the workaround for libcurl

#13472

This is on Ubuntu 3.16.0-77-generic

INFO: Initializing package repository /home/michael/.julia/v0.5
INFO: Cloning METADATA from git@git.wow.com:external/METADATA.jl.git
ERROR: error authenticating:  ssh-agent
Private key location for 'git@git.wow.com' [/home/michael/.ssh/id_rsa]:
Passphrase for /home/michael/.ssh/id_rsa:

julia> Pkg.add( "Foo" )
ERROR: error authenticating:  ssh-agentINFO: Updating cache of Foo...

Private key location for 'git@git.wow.com' [/home/michael/.ssh/id_rsa]:ERROR: error authenticating:  ssh-agent
Private key location for 'ssh://git@git.wow.com' [/home/michael/.ssh/id_rsa]:

and then just hangs ...

[mdcfrancis]

actually does not hang, requests user input for each and every repo.

[Keno]

keys are cached during Pkg.update, or can be set using environment variables. For any other usage, I'd recommend starting an ssh agent.

[mdcfrancis]

This is very different behavior from previously. I don't have to do this with regular git commands. Makes the system much less friendly.

[Keno]

How is your regular git accessing ssh credentials?

[wildart]

It looks like #17691 changed credentials caching mechanism.

[mdcfrancis]

@Keno that's a good question and one that I would have to do some research on, but basically with a standard install on ubuntu you simply don't have to worry. This was never an issue with 0.4 or with any other git client.

[Keno]

Can you see if ssh-add -l lists your key? In that case there may be an issue with how libgit2 communicates with the agent.

[mdcfrancis]

no that does not list the key - by default it is just using ~/.shh/id_rsa.pub

[Keno]

Sure, but the key appears to be encrypted? Is it not?

[mdcfrancis]

no the key is not encrypted

[Keno]

Ah, maybe that commit did not make it into rc0, can you try rc1?

[mdcfrancis]

Worse :( Pkg.init( ... ) to a local fork of METADATA hosted internally

ERROR: error authenticating: ssh-agent
ERROR: GitError(Code:ERROR, Class:SSH, Failed to authenticate SSH session: Unable to open public key file)
in macro expansion at ./libgit2/error.jl:98 [inlined]
in clone(::String, ::String, ::Base.LibGit2.CloneOptions) at ./libgit2/repository.jl:191
in #clone#109(::String, ::Bool, ::Ptr{Void}, ::Nullable{Base.LibGit2.AbstractPayload}, ::Function, ::String, ::String) at ./libgit2/libgit2.jl:320

[mdcfrancis]

I'll try and figure out what is going on

[Keno]

Ah, I think I've seen that one and have a fix. Hold on

[mdcfrancis]

With master now I just get the following

ERROR: error authenticating: ssh-agent

but it correctly works with ssh

[wildart]

Which means that your ~/.shh/id_rsa key was a correct key for the authentication, if you didn't get prompted.

@Keno I wounder can we drop this message about ssh-agent. If it fails, it fails. No harm done, so we switch to key-based authentication.

[mdcfrancis]

Yes exactly - this is working correctly, just the error message is distracting

[Keno]

Yes, we should drop the message.

[StefanKarpinski]

Isn't there a PR for this?

[Keno]

Already done.

[StefanKarpinski]

Can we have some cross references here then (and close the issue as appropriate).

[Keno]

The original issue was fixed as part of #17586 and #17651, the ssh-agent issue I did in #17860. Though there have been a couple of others in between refactoring this stuff, so there may have been other issues in between.