Permit using string macro with "qualified" name #18690
Conversation
|
The segmentation fault is strange. Is this a known issue with the nightly? |
|
I restarted your build, @TotalVerb. If it succeeds, are we ready to merge this? |
|
@JeffBezanson or @StefanKarpinski thoughts? |
|
LGTM. Should probably have a NEWS entry and/or doc mention. |
|
Added NEWS and doc entries. |
|
This is somewhat orthogonal to this PR, but the documentation on "non-standard string literals" does not mention the commonly-used synonym "string macro". Should it? |
| @@ -24,6 +24,14 @@ Language changes | |||
| This can be changed back to the original color by setting the environment variable `JULIA_INFO_COLOR` to `"blue"`. | |||
| One way of doing this is by adding `ENV["JULIA_INFO_COLOR"] = :blue` to the `.juliarc.jl` file. | |||
| For more information regarding customizing colors in the REPL, see this [manual section]( http://docs.julialang.org/en/latest/manual/interacting-with-julia/#customizing-colors). | |||
| * Multiline and singleline command macros have been added. A command macro is | |||
| like a string macro, but the syntax uses backquotes (<code>`</code>) | |||
There was a problem hiding this comment.
does this work in markdown? it's confusing the github rendering
There was a problem hiding this comment.
Ugh, markdown makes it really difficult to type backquotes in code. I think I need to escape it like `
There was a problem hiding this comment.
Updated with the backslashes and it looks like it's rendering OK:
There was a problem hiding this comment.
I sometimes do ``` which is "triple-backtick space single-backtick space triple-backtick" but whatever works
There was a problem hiding this comment.
Interesting; apparently there's no physical limit to how many backticks can be used. ``` works as well for encoding triple backticks. In general, I guess it suffices to delimit with one more consecutive backtick than will be required in the text.
But I'll probably just leave this one be, since it seems to work.
TotalVerb
force-pushed
the
fw/qualified-string-macro
branch
from
4456291 to
91ec697
Compare
|
Can someone restart the Travis build again? |
|
Needs a rebase apparently, so that'll restart it anyway. |
TotalVerb
force-pushed
the
fw/qualified-string-macro
branch
from
91ec697 to
e24cf49
Compare
|
Rebased and fixed the |
|
Would you mind fixing the conflicts? Then I think we can merge this. |
TotalVerb
force-pushed
the
fw/qualified-string-macro
branch
from
e24cf49 to
f30f60d
Compare
|
Rebased. |
| ``` q`xyz` ``` is equivalent to `@q_cmd "xyz"`. | ||
| * Nonstandard string and command literals can now be qualified with their | ||
| module. For instance, `Base.r"x"` is now parsed as `Base.@r_str "x"`. | ||
| Previously, this syntax parsed as an implicit multiplication. |
There was a problem hiding this comment.
Maybe add a link to the PR: add ([#18690]) here, and a link at the bottom.
| nonstandard command literal is like a nonstandard string literal, but the | ||
| syntax uses backquotes (``` ` ```) instead of double quotes, and the | ||
| resulting macro called is suffixed with `_cmd`. For instance, the syntax | ||
| ``` q`xyz` ``` is equivalent to `@q_cmd "xyz"`. |
There was a problem hiding this comment.
And a link here, if you can find the PR (I can't).
There was a problem hiding this comment.
Ah, it was yours: #18644
|
Nevermind, turns out I could do it. |
|
|
|
Blegh, my bad! |
|
Sorry, I thought editing the NEWS.md would be harmless; I was wrong. Fixed now. |
|
👍 no prob, thanks for the quick fix. |
@JeffBezanson raised some concerns in #14208 (comment), but I think that overall this change is fairly intuitive. Being able to call string macros that happen to have the same name in different modules is a big plus in my opinion.
Close #6970.
Close #14208.