Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1D array allocation is using jl_new_array #18922

Closed
yuyichao opened this issue Oct 14, 2016 · 1 comment · Fixed by #18917
Closed

1D array allocation is using jl_new_array #18922

yuyichao opened this issue Oct 14, 2016 · 1 comment · Fixed by #18917
Labels
performance Must go faster

Comments

@yuyichao
Copy link
Contributor

While looking at #18914 I noticed that Array(Float64, 3) (the allocation used by comprehension on master, but other constructors are the same) is calling jl_new_array which requires allocation of a tuple whereas it should be using jl_alloc_array_1d, as on 0.4 and 0.5.
@yuyichao yuyichao added the performance Must go faster label Oct 14, 2016
@JeffBezanson
Copy link
Sponsor Member

#18917 :)

@JeffBezanson JeffBezanson mentioned this issue Oct 14, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
performance Must go faster
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix specificity of sigs that are strict subtypes of vararg sigs JuliaLang/julia
2 participants
@yuyichao @JeffBezanson