getsockname mirrors UNIX getsockname now. Added getpeername. #21825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Huh? Several PR's are open that are starting a placeholder for 0.7 NEWS at the top of the file. |
tkelman
reviewed
May 13, 2017
test/socket.jl
Outdated
| default_addr = IPv4("127.0.0.1") | ||
| for (addr, porthint) in [(IPv4("127.0.0.1"), UInt16(11011)), | ||
| (IPv6("::1"), UInt16(11012)), (getipaddr(), UInt16(11013))] | ||
| port, listen_sock = listenany(addr, porthint) |
There was a problem hiding this comment.
excess indent in this block
vtjnash
approved these changes
May 15, 2017
amitmurthy
force-pushed
the
amitm/getsockname
branch
from
cd4f0c0
to
35e3896
Compare
|
Will merge after a green CI. |
tkelman
reviewed
May 30, 2017
| @@ -3,6 +3,8 @@ Julia v0.7.0 Release Notes | |||
|
|
|||
| New language features | |||
| --------------------- | |||
| * `getpeername` on a `TCPSocket` returns the address and port of the remote | |||
| endpoint of the TCP connection ([#21825]). | |||
There was a problem hiding this comment.
this is a library improvement, not a language feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #21801
NEWS.md entry will have to wait till 0.6 is released.