deprecate cholfact[!](A, uplo) #22188
Conversation
base/deprecated.jl
Outdated
| @@ -1350,6 +1350,14 @@ end | |||
| @deprecate srand(filename::AbstractString, n::Integer=4) srand(read!(filename, Array{UInt32}(Int(n)))) | |||
| @deprecate MersenneTwister(filename::AbstractString) srand(MersenneTwister(0), read!(filename, Array{UInt32}(Int(4)))) | |||
|
|
|||
| # PR ?? | |||
There was a problem hiding this comment.
would save some future work if you'd be willing to add in a news entry now
There was a problem hiding this comment.
Sure thing. Just didn't know what PR number this would end up with.
base/deprecated.jl
Outdated
| @deprecate cholfact(A::StridedMatrix, uplo::Symbol, ::Type{Val{false}}) cholfact(Hermitian(A, uplo), Val{false}) | ||
| @deprecate cholfact(A::StridedMatrix, uplo::Symbol) cholfact(Hermitian(A, uplo)) | ||
| @deprecate cholfact!(A::StridedMatrix, uplo::Symbol, ::Type{Val{true}}; tol = 0.0) cholfact!(Hermitian(A, uplo), Val{true}, tol = tol) | ||
| @deprecate cholfact(A::StridedMatrix, uplo::Symbol, ::Type{Val{true}}; tol = 0.0) cholfact(Hermitian(A, uplo), Val{true}, tol=tol) |
There was a problem hiding this comment.
Negligible, but inconsistent spacing around the keyword argument line to line? :)
| @@ -94,18 +91,12 @@ using Base.LinAlg: BlasComplex, BlasFloat, BlasReal, QRPivoted, PosDefException | |||
| U = Bidiagonal([2,sqrt(eltya(3))],[-1],true) / sqrt(eltya(2)) | |||
| @test full(chol(S)) ≈ full(U) | |||
|
|
|||
| #lower Cholesky factor | |||
There was a problem hiding this comment.
Comment worth preserving/revising?
There was a problem hiding this comment.
I thought it only applied to the tests which are now deprecated? Both Hermitian(A, :U) and Hermitian(A, :L) are tested in the tests just below.
There was a problem hiding this comment.
My suggestion to preserve/revise the comment associated with that block was independent of whether that comment applies primarily or strictly to the deprecated tests: There is no other comment describing the surviving contents of that block, and having an up to date comment describing the remaining tests in that block would be worthwhile :).
There was a problem hiding this comment.
Makes sense! I will add something descriptive :)
There was a problem hiding this comment.
Done! Moved around some things, I think it is clearer now.
There was a problem hiding this comment.
If you mean that the comment added on line 61 should also apply to this block, perhaps move this block adjacent to the block to which that comment is attached (rather than leave those blocks separated by the block dedicated to Strang matrices)? Forty lines, paragraph breaks, and other comments interceding obscures the relationship :).
There was a problem hiding this comment.
Hmm, I confused myself. Actually, there is no reason not to merge the two blocks, I will do that.
There was a problem hiding this comment.
Ended up adding a comment instead.
fredrikekre
force-pushed
the
fe/cholesky-uplo
branch
2 times, most recently
from
5fc2d2d
to
1ae54ff
Compare
fredrikekre
changed the title
fredrikekre
force-pushed
the
fe/cholesky-uplo
branch
from
1ae54ff
to
09a255a
Compare
restructure the cholesky test
fredrikekre
force-pushed
the
fe/cholesky-uplo
branch
from
09a255a
to
80aa8b7
Compare
|
Rebased. |
Fix #22187