Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement union!, intersect!, setdiff! for non-sets #23524

Closed
StefanKarpinski opened this issue Aug 31, 2017 · 4 comments
Closed

implement union!, intersect!, setdiff! for non-sets #23524

StefanKarpinski opened this issue Aug 31, 2017 · 4 comments
Assignees
@rfourquet
Labels
good first issue Indicates a good issue for first-time contributors to Julia

Comments

@StefanKarpinski
Copy link
Member

We already have the mutating set operators for Set objects, but they make sense for vectors as well, which have the non-mutating versions already. The mutating operations should work on vectors as well.
@StefanKarpinski StefanKarpinski added good first issue Indicates a good issue for first-time contributors to Julia help wanted Indicates that a maintainer wants help on an issue or pull request labels Aug 31, 2017
@rfourquet rfourquet self-assigned this Aug 31, 2017
@Vaibhavdixit02
Copy link
Contributor

I would like to work on this issue, is it still up for grabs?

@rfourquet
Copy link
Member

I have been working on this already in the last couple weeks, as a complentary PR to #23528 (that's why I assigned myself here).

@rfourquet rfourquet removed the help wanted Indicates that a maintainer wants help on an issue or pull request label Sep 2, 2017
@rfourquet
Copy link
Member

@Vaibhavdixit02 If you feel like reviewing, please check #23528.

@rfourquet
Copy link
Member

Closed by #23528.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rfourquet rfourquet

Labels
good first issue Indicates a good issue for first-time contributors to Julia
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@StefanKarpinski @rfourquet @Vaibhavdixit02