deprecate expand(module, ex) to Meta.lower(module, ex) #24278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sacha0
added
deprecation
Sacha0
force-pushed
the
expandlower
branch
2 times, most recently
from
a885ba7
to
687ba4d
Compare
ararslan
approved these changes
Oct 22, 2017
Sacha0
force-pushed
the
expandlower
branch
2 times, most recently
from
385177d
to
1d4cbcb
Compare
fredrikekre
reviewed
Oct 23, 2017
NEWS.md
Outdated
| @@ -383,6 +383,9 @@ Deprecated or removed | |||
| which now require a module argument. | |||
| And it caused the bugfix of other default arguments to use the Main module (including `whos`, `which`). | |||
|
|
|||
| * `expand(ex)` and `expand(module, ex)` have been deprecated in favor of | |||
There was a problem hiding this comment.
Perhaps add a reference to #22064 and mention that expand(ex) is deprecated as well? There does not seem to be any news about that deprecation, and makes sense to mention them both in the same bullet point here.
There was a problem hiding this comment.
NEWS.md
Outdated
| @@ -383,6 +383,9 @@ Deprecated or removed | |||
| which now require a module argument. | |||
| And it caused the bugfix of other default arguments to use the Main module (including `whos`, `which`). | |||
|
|
|||
| * `expand(ex)` and `expand(module, ex)` have been deprecated in favor of | |||
| `Meta.lower(ex)` ([#24278]). | |||
There was a problem hiding this comment.
Good catch! Fixed. Thanks! :)
|
Absent objections or requests for time, I plan to merge these changes tomorrow. Best! |
|
Thanks all! :) |
StefanKarpinski
pushed a commit
that referenced
this pull request
Jan 2, 2018
Ran NEWS-update.jl to refresh link references.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request deprecates
expand([module, ]ex)toMeta.lower(module, ex), addressing #23808. Best!