Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deprecate bits to bitstring #24281

Merged
merged 1 commit into from
Oct 25, 2017
Merged

deprecate bits to bitstring #24281

merged 1 commit into from
Oct 25, 2017

Conversation

Sacha0
Copy link
Member

@Sacha0 Sacha0 commented Oct 23, 2017

This pull request deprecates bits to bitstring, addressing #24263. Best!

@Sacha0 Sacha0 added deprecation This change introduces or involves a deprecation triage This should be discussed on a triage call labels Oct 23, 2017
@Sacha0 Sacha0 force-pushed the bitstring branch 2 times, most recently from b1444a4 to 33c2ba6 Compare October 23, 2017 02:39
@Sacha0 Sacha0 mentioned this pull request Oct 23, 2017
Merged
@Sacha0 Sacha0 force-pushed the bitstring branch 2 times, most recently from 49b7a84 to 2eaa6c3 Compare October 23, 2017 04:37
fredrikekre
fredrikekre approved these changes Oct 23, 2017
View reviewed changes
NEWS.md Outdated
@@ -556,8 +556,9 @@ Deprecated or removed
`ReinterpretArray`. The three argument form of `reinterpret` that implicitly reshapes
has been deprecated ([#23750]).

* `num2hex` and `hex2num` have been deprecated in favor of `reinterpret` combined with `parse`/`hex`
([#22088])
* `bits` has been deprecated in favor of `bitstring` ([#WHATAREBIRDS]).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

([#24281])

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or #24263

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added both. Thanks!

base/deprecated.jl Outdated
@@ -1913,6 +1913,9 @@ end
@deprecate float(x::AbstractString) parse(Float64, x)
@deprecate float(a::AbstractArray{<:AbstractString}) parse.(Float64, a)

# deprecate bits to bitstring
@deprecate bits(x) bitstring(x)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose this could be @deprecate bits bitstring?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call! Simplified. Thanks! :)

@JeffBezanson JeffBezanson removed the triage This should be discussed on a triage call label Oct 25, 2017
@JeffBezanson JeffBezanson merged commit 3b94a9e into JuliaLang:master Oct 25, 2017
@Sacha0
Copy link
Member Author

Sacha0 commented Oct 26, 2017

Thanks all! :)

@Sacha0 Sacha0 deleted the bitstring branch October 26, 2017 00:39
@JeffBezanson JeffBezanson mentioned this pull request Oct 26, 2017
Closed
@cormullion cormullion mentioned this pull request Mar 18, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JeffBezanson JeffBezanson JeffBezanson left review comments

@fredrikekre fredrikekre fredrikekre approved these changes

Assignees
No one assigned
Labels
deprecation This change introduces or involves a deprecation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Sacha0 @JeffBezanson @fredrikekre